Skip to content

[SYCL] Add sycl_ext_intel_math_inv #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2023
Merged

[SYCL] Add sycl_ext_intel_math_inv #8138

merged 4 commits into from
Feb 9, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jan 29, 2023 •
edited
Loading

This PR aims to add sycl::ext::intel::math::inv for fp32, fp64, half, half2 to sycl intel math header. The real implementation has been provided by SYCL device library via __imf_inv/invf16/invf.

@jinge90 jinge90 requested a review from a team as a code owner January 29, 2023 03:13
@jinge90 jinge90 requested a review from bso-intel January 29, 2023 03:13
@jinge90
Copy link
Contributor Author

jinge90 commented Jan 29, 2023

Hi, @zettai-reido and @akolesov-intel
Could you take a look at this PR?
Thanks very much.

@jinge90 jinge90 temporarily deployed to aws January 29, 2023 03:37 — with GitHub Actions Inactive
zettai-reido
zettai-reido approved these changes Jan 29, 2023
View reviewed changes
Copy link

@zettai-reido zettai-reido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinge90 jinge90 temporarily deployed to aws January 29, 2023 09:43 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jan 31, 2023

Hi, @intel/llvm-reviewers-runtime and @bso-intel
Could you take a look at this PR?
Thanks very much.

@aelovikov-intel
Copy link
Contributor

Where is the test PR for this?

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 1, 2023

Where is the test PR for this?

Hi, @aelovikov-intel
This PR aims to add a new API "inv" in sycl::intel::ext::math, this API is required by SYCLomatic tool. This API depends on "__imf_inv" provided by libdevice.
Thanks very much.

@aelovikov-intel
Copy link
Contributor

It doesn't need mean we don't need to test this new API as part of this project.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 2, 2023

It doesn't need mean we don't need to test this new API as part of this project.

Hi, @aelovikov-intel
I will add a test in llvm-test-suite and once this PR is merged, SYCLomatic developers will add test in their side too.
Thanks very much.

@jinge90 jinge90 mentioned this pull request Feb 3, 2023
Open
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 3, 2023

/verify with intel/llvm-test-suite#1571

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 6, 2023

Where is the test PR for this?

Hi, @aelovikov-intel
The test PR is in intel/llvm-test-suite#1571
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 7, 2023

/verify with intel/llvm-test-suite#1571

@jinge90 jinge90 temporarily deployed to aws February 7, 2023 07:28 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws February 7, 2023 13:34 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 8, 2023

Hi, @bso-intel
Could you take a look at this PR?
Thanks very much.

bso-intel
bso-intel approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 9, 2023

Hi, @bader and @aelovikov-intel
Could you help merge this PR?
Thanks very much.

@bader
Copy link
Contributor

bader commented Feb 9, 2023

Could you help merge this PR?

@jinge90, please, ping @intel/llvm-gatekeepers team for future merge requests.

More on that here - https://github.com/intel/llvm/blob/sycl/CONTRIBUTING.md#merge.

@bader
Copy link
Contributor

bader commented Feb 9, 2023

Please, add [SYCL] tag to the PR title.

@jinge90 jinge90 changed the title Add sycl_ext_intel_math_inv [SYCL]Add sycl_ext_intel_math_inv Feb 9, 2023
@jinge90 jinge90 changed the title [SYCL]Add sycl_ext_intel_math_inv [SYCL] Add sycl_ext_intel_math_inv Feb 9, 2023
@jinge90 jinge90 requested a review from a team February 9, 2023 00:37
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 9, 2023

Hi, @intel/llvm-gatekeepers
Could you help merge this patch?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Feb 9, 2023

Please, add [SYCL] tag to the PR title.

Done.
Thanks very much.

@bader bader merged commit a90d0fd into intel:sycl Feb 9, 2023
@jinge90 jinge90 deleted the add_rcp_to_imf branch February 9, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bso-intel bso-intel bso-intel approved these changes

@akolesov-nv akolesov-nv akolesov-nv approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@zettai-reido zettai-reido zettai-reido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jinge90 @aelovikov-intel @bader @bso-intel @akolesov-nv @zettai-reido